Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): sw-2822 activate ansible aap managed #1389

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 16, 2024

What's included

  • feat(config): sw-2822 activate ansible aap managed

Notes

  • per the ROSA configuration we also left the use_running_totals_format tally/capacity query param set to true

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. confirm display has the correct metrics display
    • confirm the instances inventory display shows the correct fields
    • confirm the subscriptions inventory display shows the correct fields

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

Screenshot 2024-08-20 at 13-43-31 Standalone Curiosity

Updates issue/story

sw-2822

@cdcabrera cdcabrera added the 202412 project phase label Aug 16, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 80.39216% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.40%. Comparing base (3d816df) to head (dda59c3).

Files with missing lines Patch % Lines
src/config/product.ansible.js 80.39% 9 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   91.52%   91.40%   -0.13%     
==========================================
  Files         115      116       +1     
  Lines        4557     4608      +51     
  Branches     1936     1966      +30     
==========================================
+ Hits         4171     4212      +41     
- Misses        358      367       +9     
- Partials       28       29       +1     
Files with missing lines Coverage Δ
src/services/rhsm/rhsmConstants.js 100.00% <ø> (ø)
src/services/rhsm/rhsmServices.js 100.00% <ø> (ø)
src/config/product.ansible.js 80.39% <80.39%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d816df...dda59c3. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review August 20, 2024 17:46
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
public/locales/en-US.json Outdated Show resolved Hide resolved
@cdcabrera cdcabrera added the hold label Sep 3, 2024
@cdcabrera cdcabrera force-pushed the main branch 2 times, most recently from e00dc2a to 2e8838f Compare September 9, 2024 15:33
@cdcabrera cdcabrera removed the hold label Sep 12, 2024
@cdcabrera cdcabrera merged commit c774815 into RedHatInsights:main Sep 12, 2024
6 of 8 checks passed
@cdcabrera cdcabrera mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants