Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 of 4, fix(authentication): consistent locale keys #1434

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • refactor(authentication): sw-2479 consistent locale keys
    • locale, auth keys
    • authentication, updated auth keys, test snapshots
    • messageView, allow component or func ref

Notes

  • clean up exposed while updating sw-2479
  • there should be no visual difference to an end user

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

related sw-2479 #1433 #1432 #1416

@cdcabrera cdcabrera added the 202412 project phase label Oct 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (11b266c) to head (d303c77).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   91.58%   91.58%           
=======================================
  Files         115      115           
  Lines        4597     4599    +2     
  Branches     1965     1967    +2     
=======================================
+ Hits         4210     4212    +2     
  Misses        361      361           
  Partials       26       26           
Files with missing lines Coverage Δ
src/components/authentication/authentication.js 100.00% <100.00%> (ø)
src/components/messageView/messageView.js 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b266c...d303c77. Read the comment docs.

@cdcabrera cdcabrera changed the title fix(authentication): consistent locale keys 4 of 4, fix(authentication): consistent locale keys Oct 3, 2024
* locale, auth keys
* authentication, updated auth keys, test snapshots
* messageView, allow component or func ref
@cdcabrera cdcabrera marked this pull request as ready for review October 3, 2024 14:34
@cdcabrera cdcabrera merged commit 787db24 into RedHatInsights:main Oct 3, 2024
9 of 11 checks passed
@cdcabrera cdcabrera mentioned this pull request Oct 10, 2024
cdcabrera added a commit that referenced this pull request Oct 10, 2024
* locale, auth keys
* authentication, updated auth keys, test snapshots
* messageView, allow component or func ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants