Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pagination,productView): sw-2707 remove deprecated react #1451

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • refactor(pagination,productView): sw-2707 remove deprecated react

Notes

  • removes default props and types

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-2707

@cdcabrera cdcabrera added the 202412 project phase label Oct 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.48%. Comparing base (571b0bb) to head (e8b43c0).

Files with missing lines Patch % Lines
src/components/pagination/pagination.js 90.00% 1 Missing ⚠️
src/components/productView/productViewMissing.js 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
- Coverage   91.52%   91.48%   -0.04%     
==========================================
  Files         115      115              
  Lines        4612     4618       +6     
  Branches     2018     2030      +12     
==========================================
+ Hits         4221     4225       +4     
- Misses        365      367       +2     
  Partials       26       26              
Files with missing lines Coverage Δ
src/components/productView/productView.js 95.00% <100.00%> (-0.46%) ⬇️
src/components/pagination/pagination.js 92.85% <90.00%> (-7.15%) ⬇️
src/components/productView/productViewMissing.js 75.00% <75.00%> (-2.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571b0bb...e8b43c0. Read the comment docs.

@cdcabrera cdcabrera merged commit cedeb83 into RedHatInsights:main Oct 21, 2024
9 of 11 checks passed
@cdcabrera cdcabrera mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants