Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): lock reset, bump group with 9 updates #1457

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Oct 24, 2024

What's included

  • build(deps): lock reset, bump group with 9 updates
    • @patternfly/patternfly from 5.3.1 to 5.4.2
    • @patternfly/react-charts from 7.3.0 to 7.4.5
    • @patternfly/react-core from 5.3.4 to 5.4.2
    • @patternfly/react-icons from 5.3.2 to 5.4.0
    • @patternfly/react-styles from 5.3.1 to 5.4.1
    • @patternfly/react-table from 5.3.4 to 5.4.8
    • @patternfly/react-tokens from 5.3.1 to 5.4.1
    • victory from 37.0.2 to 37.2.0
    • victory-create-container from 37.0.2 to 37.2.0

Notes

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. confirm visual graph updates
    • confirm graph tooltip functionality
    • confirm graph legend behavior
      • confirm tooltip functionality

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

null is now represented as "empty" in the graph display regardless of interpolation. before the graph would attempt to smooth over the area. this is mostly expected behavior, the local RHEL demo shown below shows extreme variations in data for development purposes only. the mock apis have the ability to return 0, undefined and null but the general API response falls back to using just 0, even when has_data is used. we're reasonably confident the expected result will be the default
new expected result
Screenshot 2024-10-24 at 11 43 01 AM
new extreme possible result (if the API returns null or undefined)
Screenshot 2024-10-24 at 11 00 06 AM

current
Screenshot 2024-10-24 at 10 57 39 AM

Updates issue/story

ongoing
relates to #1456

@cdcabrera cdcabrera added build 202412 project phase labels Oct 24, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (28835cd) to head (a097845).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1457   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files         115      115           
  Lines        4637     4637           
  Branches     2054     2054           
=======================================
  Hits         4242     4242           
  Misses        369      369           
  Partials       26       26           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28835cd...a097845. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review October 24, 2024 15:18
* @patternfly/patternfly from 5.3.1 to 5.4.2
* @patternfly/react-charts from 7.3.0 to 7.4.5
* @patternfly/react-core from 5.3.4 to 5.4.2
* @patternfly/react-icons from 5.3.2 to 5.4.0
* @patternfly/react-styles from 5.3.1 to 5.4.1
* @patternfly/react-table from 5.3.4 to 5.4.8
* @patternfly/react-tokens from 5.3.1 to 5.4.1
* victory from 37.0.2 to 37.2.0
* victory-create-container from 37.0.2 to 37.2.0
@cdcabrera cdcabrera merged commit 756eb5a into RedHatInsights:main Oct 28, 2024
9 of 11 checks passed
@cdcabrera cdcabrera mentioned this pull request Oct 30, 2024
cdcabrera added a commit that referenced this pull request Oct 30, 2024
* @patternfly/patternfly from 5.3.1 to 5.4.2
* @patternfly/react-charts from 7.3.0 to 7.4.5
* @patternfly/react-core from 5.3.4 to 5.4.2
* @patternfly/react-icons from 5.3.2 to 5.4.0
* @patternfly/react-styles from 5.3.1 to 5.4.1
* @patternfly/react-table from 5.3.4 to 5.4.8
* @patternfly/react-tokens from 5.3.1 to 5.4.1
* victory from 37.0.2 to 37.2.0
* victory-create-container from 37.0.2 to 37.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants