-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a user opt-in form for org-admins #247
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3152662
to
8790cf6
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Apr 9, 2020
* build, proxy run path adjusted * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
9d7ff17
to
146f00e
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Apr 9, 2020
* build, proxy run path adjusted * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
146f00e
to
94cd2c7
Compare
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Apr 10, 2020
* build, proxy run path adjusted * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
94cd2c7
to
ce54220
Compare
* build, proxy run path adjusted * build, dist test updated to avoid including platform config * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
ce54220
to
18cb2ae
Compare
|
Merged
cdcabrera
added a commit
that referenced
this pull request
Apr 10, 2020
* build, proxy run path adjusted * build, dist test updated to avoid including platform config * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
This was referenced Apr 10, 2020
Merged
cdcabrera
added a commit
that referenced
this pull request
Apr 17, 2020
* build, proxy run path adjusted * build, dist test updated to avoid including platform config * i18n, locales, strings for opt-in * authentication, add in admin checks * optinView, add component * routerTypes, add and apply error routing for opt-in * userActions, notifications for opt-in success/fail * userReducer, carry admin and entitled through error state * userServices, add in opt-in put force status for mock testing * styling, added images, minor adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
/subscriptions/optin
403
is NOT thrown and you're an admin should probably disabled the button, currently it does not. Regular users aren't a concern, they receive the opt in view sans button.Process for "opt-in" breakdown
Contact us
link indicating they can not proceed.How to test
Local run check
$ yarn
.env.local
to the root of the project.env.local
,REACT_APP_DEBUG_ORG_ADMIN=true
$ yarn start
REACT_APP_DEBUG_ORG_ADMIN=true
or change it toREACT_APP_DEBUG_ORG_ADMIN=false
,$ yarn start
.Example
Recordings
Updates issue/story
#240