feat(inventoryList,views): issues/10 display inventory list #372

cdcabrera · 2020-08-11T08:08:23Z

What's included

fix(table,tableSkeleton): issues/10 align content prop to pf 
- table, pf fixme annotations, align to pf title/content prop
- tableSkeleton, switch to generic node, related to pf title align
fix(inventoryListSelectors): issues/10 itemCount, deep equals 
- inventoryListSelectors, itemCount, deep equals adjustment
- rhsmApiTypes, added inventory_id
- reduxHelpers add setNormalizedResponse
- rhsmServices mock update
feat(inventoryList,views): issues/10 display inventory list 
- inventoryList, initial inventory list display
- inventoryListHelpers, parse table cells
- inventoryList perPageDefault for skeleton loader
- pagination, initial pagination
- rhelView, openshiftView add inventoryList
- locale, i18n strings
- styles, min-heights graphCard, inventoryList
fix(graphCard,c3GraphCard): issues/10 align card component 
- c3GraphCard, align to graphCard
- graphCard, align to inventoryList card

Notes

This activates the basic inventory display. The "guests" table display is planned for the next increment.

How to test

Proxy run check

update the NPM packages with $ yarn
make sure Docker is running, plus on network, then
$ yarn start:proxy
Confirm the inventory is displaying

Example

Updates issue/story

Updates #10

…nsights#372) * table, pf fixme annotations, align to pf title/content prop * tableSkeleton, switch to generic node, related to pf title align

…Insights#372) * inventoryListSelectors, itemCount, deep equals adjustment * rhsmApiTypes, added inventory_id * reduxHelpers add setNormalizedResponse * rhsmServices mock update

…sights#372) * styles, min-heights graphCard, inventoryList * inventoryList, initial inventory list display * inventoryListHelpers, parse table cells * inventoryList perPageDefault for skeleton loader * pagination, initial pagination * rhelView, openshiftView add inventoryList * locale, i18n strings

…ights#372) * c3GraphCard, align to graphCard * graphCard, align to inventoryList card

codecov-commenter · 2020-08-11T20:22:08Z

Codecov Report

Merging #372 into ci will increase coverage by 0.07%.
The diff coverage is 92.66%.

@@            Coverage Diff             @@
##               ci     #372      +/-   ##
==========================================
+ Coverage   92.47%   92.54%   +0.07%     
==========================================
  Files          64       67       +3     
  Lines        1528     1637     +109     
  Branches      355      376      +21     
==========================================
+ Hits         1413     1515     +102     
- Misses        100      107       +7     
  Partials       15       15

Impacted Files	Coverage Δ
src/services/rhsmServices.js	`100.00% <ø> (ø)`
src/types/rhsmApiTypes.js	`100.00% <ø> (ø)`
src/components/table/table.js	`87.75% <69.23%> (-0.35%)`	⬇️
src/components/rhelView/rhelView.js	`92.30% <85.71%> (-7.70%)`	⬇️
src/components/inventoryList/inventoryList.js	`88.88% <88.88%> (ø)`
src/components/pagination/pagination.js	`88.88% <88.88%> (ø)`
src/components/openshiftView/openshiftView.js	`96.96% <92.85%> (-3.04%)`	⬇️
src/components/c3GraphCard/c3GraphCard.js	`88.67% <100.00%> (ø)`
src/components/graphCard/graphCard.js	`83.67% <100.00%> (ø)`
...c/components/inventoryList/inventoryListHelpers.js	`100.00% <100.00%> (ø)`
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa88ec9...5a94bda. Read the comment docs.

* table, pf fixme annotations, align to pf title/content prop * tableSkeleton, switch to generic node, related to pf title align

* inventoryListSelectors, itemCount, deep equals adjustment * rhsmApiTypes, added inventory_id * reduxHelpers add setNormalizedResponse * rhsmServices mock update

* styles, min-heights graphCard, inventoryList * inventoryList, initial inventory list display * inventoryListHelpers, parse table cells * inventoryList perPageDefault for skeleton loader * pagination, initial pagination * rhelView, openshiftView add inventoryList * locale, i18n strings

ntkathole · 2020-08-12T06:16:23Z

Hi @cdcabrera looks like it broke granularity. Graph is not displayed as per correct dates (Today its 12 Aug and screenshot showing 22 July for daily) and also x-axis values displayed are changed.