Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphCard): issues/380 graph refresh on query #384

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(graphCard): issues/380 graph refresh on query

Notes

  • Introduced a minor refresh bug associated with the graph when switching between product architectures and granularity while trying to focus the global "limit" to inventory

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. this fix corrects the below bug/issue... this should no longer happen
    1. Select the RHEL product
    2. disable all of the graph legend facets, then
    3. navigating down the RHEL architectures, then back up the architectures, and stop on all
    4. re-enabling all of the graph legend facets, the graph would not turn back on

Example

...

Updates issue/story

#10 #380

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #384 into ci will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #384   +/-   ##
=======================================
  Coverage   92.48%   92.48%           
=======================================
  Files          68       68           
  Lines        1649     1649           
  Branches      381      381           
=======================================
  Hits         1525     1525           
  Misses        108      108           
  Partials       16       16           
Impacted Files Coverage Δ
src/components/graphCard/graphCard.js 84.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147bbcd...e658000. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants