Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openshiftView): issues/383 umo to uom #411

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Sep 8, 2020

What's included

  • fix(openshiftView): issues/383 umo to uom
  • fix(openshiftView): issues/383 xhr double jump
    • openshiftView, set default props, avoid xhr double jump

Notes

  • Silly spelling correction
  • Applies additional default props update. Appears we need to look at removing the "initialOptions" prop in OpenShift in favor of using the "query" instead. This should be handled once the card toolbar component is considered #407

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. navigate to the Openshift product view
  5. open the browser dev console network tab
  6. in the GUI select either the "cores" or "sockets" option from the "graph card toolbar"
  7. observe the network call for inventory having the "umo" "uom" query string filter applied
    • a secondary observation can be made in the fact that the "skeleton table loader" previously did not fire/reload when either "cores" or "sockets" was selected, it now does and represents the API updating

Example

...

Updates issue/story

#383

@cdcabrera cdcabrera merged commit 7826496 into RedHatInsights:ci Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant