Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inventoryList): issues/476 show field on zero results #556

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 21, 2021

What's included

  • fix(inventoryList): issues/476 show field on zero results
  • fix(toolbarFieldDisplayName): issues/476 allow enter submit

Notes

  • based on UX/design feedback reactivates the display name field. accounts for scenarios in which zero results normally hides "paging". the new behavior is to now display paging and the display name field when there are "zero" results
  • enables a user to use the enter/return key to submit the display name field
  • have a question around the paging disabled state, do we want to remove the grey disabled color? @bclarhk @rblackbu

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login with an account having a hosts inventory
  5. navigate to a RHEL architecture and enter a display name search that yields zero results, the result should be similar to the below screenshot example
    • Also confirm that switching between RHEL architectures both maintains the value in the display name field, adjusts the results based off of "all", and allows you to still edit display name

Example

Accepted solution

Screen Shot 2021-01-21 at 11 01 08 AM

NOT accepted, prior solution with paging disabled and showing

Screen Shot 2021-01-21 at 10 13 29 AM

Updates issue/story

#476

@cdcabrera cdcabrera changed the title WIP fix(inventoryList): issues/476 show field on zero results fix(inventoryList): issues/476 show field on zero results Jan 21, 2021
@cdcabrera cdcabrera requested review from bclarhk and rblackbu January 21, 2021 15:16
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 21, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Jan 21, 2021
@cdcabrera cdcabrera force-pushed the issues/476-displayname branch from 13ccf16 to 2f9996a Compare January 21, 2021 15:40
@codecov-io
Copy link

Codecov Report

Merging #556 (2f9996a) into ci (b693fb7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #556   +/-   ##
=======================================
  Coverage   93.95%   93.96%           
=======================================
  Files          83       83           
  Lines        2448     2451    +3     
  Branches      840      843    +3     
=======================================
+ Hits         2300     2303    +3     
  Misses        128      128           
  Partials       20       20           
Impacted Files Coverage Δ
src/components/form/checkbox.js 100.00% <ø> (ø)
src/components/form/formHelpers.js 100.00% <100.00%> (ø)
src/components/form/textInput.js 96.87% <100.00%> (-0.43%) ⬇️
src/components/inventoryList/inventoryList.js 91.30% <100.00%> (-0.25%) ⬇️
src/components/toolbar/toolbarFieldDisplayName.js 86.36% <100.00%> (+4.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b693fb7...2f9996a. Read the comment docs.

…sights#556)

* formHelpers, mock event helper
* checkbox, textInput, mock event helper, key down event
* toolbarFieldDisplayName, enter key for submit
@cdcabrera cdcabrera force-pushed the issues/476-displayname branch from 2f9996a to 6b5189c Compare January 21, 2021 16:14
Copy link

@bclarhk bclarhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. I approve :-D

@cdcabrera cdcabrera merged commit 0f25e8a into RedHatInsights:ci Jan 21, 2021
cdcabrera added a commit that referenced this pull request Jan 21, 2021
* formHelpers, mock event helper
* checkbox, textInput, mock event helper, key down event
* toolbarFieldDisplayName, enter key for submit
cdcabrera added a commit that referenced this pull request Jan 27, 2021
* formHelpers, mock event helper
* checkbox, textInput, mock event helper, key down event
* toolbarFieldDisplayName, enter key for submit
cdcabrera added a commit that referenced this pull request Feb 1, 2021
* formHelpers, mock event helper
* checkbox, textInput, mock event helper, key down event
* toolbarFieldDisplayName, enter key for submit
cdcabrera added a commit that referenced this pull request Feb 16, 2021
* formHelpers, mock event helper
* checkbox, textInput, mock event helper, key down event
* toolbarFieldDisplayName, enter key for submit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants