Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/476 displayname field, remove tab content focus outline #557

Merged
merged 2 commits into from
Jan 21, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jan 21, 2021

What's included

  • fix(textInput,toolbarFieldDisplayName): issues/476 clean up, extra props
  • fix(style): remove focus outline style for tab content

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. log in and confirm the tab focus outline is no longer visible on the hosts inventory display by
    • either tabbing through the interface
    • or click next to, around, the display name field

Example

After

Screen Shot 2021-01-21 at 3 07 50 PM

Before

Screen Shot 2021-01-21 at 3 07 32 PM

Updates issue/story

Relates to #476

@codecov-io
Copy link

Codecov Report

Merging #557 (6f9cbca) into ci (0f25e8a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #557   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          83       83           
  Lines        2453     2453           
  Branches      845      845           
=======================================
  Hits         2305     2305           
  Misses        128      128           
  Partials       20       20           
Impacted Files Coverage Δ
src/components/form/textInput.js 96.87% <100.00%> (ø)
src/components/toolbar/toolbarFieldDisplayName.js 86.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f25e8a...6f9cbca. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants