Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(toolbarFieldDisplayName): issues/476 search-as-type #572

Merged
merged 2 commits into from
Feb 4, 2021
Merged

fix(toolbarFieldDisplayName): issues/476 search-as-type #572

merged 2 commits into from
Feb 4, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 2, 2021 •
edited
Loading

What's included

  • fix(toolbarFieldDisplayName): issues/476 search-as-type
    • testing, mock for debounce
    • textInput, emulate onClear for non-search types
    • toolbarFieldDisplayName, debounce on keyup, style adjustment
    • rhsmServices, adjust emulated API delays to reflect environments
  • fix(i18n): consistent mock emulation

Notes

  • applies a "search as you type" to the display name filter
  • we use a similar 800 ms delay on the input field similar to the platform's inventory search. what this means is that there is a noticeable delay after typing. we can attempt to adjust this timer, but the current adjustment makes allowances for persons typing at varying speeds

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. login, navigate to Subs Watch, confirm the display name search field functions

Example

Updated

Screen Shot 2021-02-02 at 12 28 57 PM

Current

Screen Shot 2021-02-02 at 12 30 18 PM

Updates issue/story

#476

@cdcabrera cdcabrera force-pushed the issues/476-typesearch branch from 54dce6b to 4b9e966 Compare February 2, 2021 18:47
@codecov-io
Copy link

Codecov Report

Merging #572 (4b9e966) into ci (f59a07e) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #572      +/-   ##
==========================================
- Coverage   94.08%   93.99%   -0.09%     
==========================================
  Files          84       84              
  Lines        2061     2499     +438     
  Branches      522      857     +335     
==========================================
+ Hits         1939     2349     +410     
- Misses        102      130      +28     
  Partials       20       20
Impacted Files Coverage Δ
src/services/rhsmServices.js 100.00% <ø> (ø)
src/components/form/textInput.js 97.29% <100.00%> (+0.74%) ⬆️
src/components/toolbar/toolbarFieldDisplayName.js 93.10% <100.00%> (+3.10%) ⬆️
src/components/router/redirect.js 65.00% <0.00%> (-5.59%) ⬇️
src/components/router/routerHelpers.js 91.42% <0.00%> (-5.45%) ⬇️
src/redux/selectors/subscriptionsListSelectors.js 97.22% <0.00%> (-2.78%) ⬇️
src/redux/selectors/inventoryListSelectors.js 97.50% <0.00%> (-2.50%) ⬇️
...s/inventorySubscriptions/inventorySubscriptions.js 90.76% <0.00%> (-2.42%) ⬇️
src/services/platformServices.js 97.67% <0.00%> (-2.33%) ⬇️
src/components/inventoryList/inventoryList.js 91.66% <0.00%> (-2.09%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f59a07e...4b9e966. Read the comment docs.

@cdcabrera cdcabrera force-pushed the issues/476-typesearch branch 2 times, most recently from 06cc63d to ca27a19 Compare February 4, 2021 01:58
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 4, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (RedHatInsigh…
8a25c49 
…ts#572)

* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Feb 4, 2021
@cdcabrera
fix(i18n): consistent mock emulation (RedHatInsights#572)
2cbc876
@cdcabrera cdcabrera force-pushed the issues/476-typesearch branch 2 times, most recently from 2cbc876 to 1cf58a0 Compare February 4, 2021 02:10
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (RedHatInsigh…
f4170ae 
…ts#572)

* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
@cdcabrera
fix(i18n): consistent mock emulation (RedHatInsights#572)
f7654f6
@cdcabrera cdcabrera force-pushed the issues/476-typesearch branch from 1cf58a0 to f7654f6 Compare February 4, 2021 02:23
@cdcabrera cdcabrera merged commit 30d0728 into RedHatInsights:ci Feb 4, 2021
cdcabrera added a commit that referenced this pull request Feb 4, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
bf7159d 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Feb 16, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
8a238d9 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Feb 16, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
f2405fb
@cdcabrera cdcabrera mentioned this pull request Mar 4, 2021
Merged
cdcabrera added a commit that referenced this pull request Mar 5, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
eeedfaf 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Mar 5, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
ba740be
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (RedHatInsigh…
b306aec 
…ts#572)

* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
@cdcabrera
fix(i18n): consistent mock emulation (RedHatInsights#572)
afe1add
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (RedHatInsigh…
87cdc3a 
…ts#572)

* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
@cdcabrera
fix(i18n): consistent mock emulation (RedHatInsights#572)
4616e73
cdcabrera added a commit that referenced this pull request Mar 25, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
c52b0a7 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Mar 25, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
1621aa6
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
63e5ea3 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
1d2afee
@cdcabrera cdcabrera mentioned this pull request Apr 13, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
0784430 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
a4db6ce
@cdcabrera cdcabrera mentioned this pull request Apr 20, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 20, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
69dceac 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Apr 20, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
2f632db
@cdcabrera cdcabrera mentioned this pull request Apr 22, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 26, 2021
@cdcabrera
fix(toolbarFieldDisplayName): issues/476 search-as-type (#572)
61a5b1f 
* testing, mock for debounce
* textInput, emulate onClear for non-search types
* toolbarFieldDisplayName, debounce on keyup, style adjustment
* rhsmServices, adjust emulated API delays to reflect environments
cdcabrera added a commit that referenced this pull request Apr 26, 2021
@cdcabrera
fix(i18n): consistent mock emulation (#572)
4d3ff2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cdcabrera @codecov-io