Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pageHeader): ent-3533 check consistent html for Pendo #580

Merged
merged 1 commit into from
Feb 9, 2021
Merged

fix(pageHeader): ent-3533 check consistent html for Pendo #580

merged 1 commit into from
Feb 9, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(pageHeader): ent-3533 check consistent html for Pendo

Notes

  • renders the html output into a snapshot for future PF and platform component update diffs. Pendo is affected by a sensitive CCS selector regardless of having a dedicated CSS class name.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm all tests pass

Example

...

Updates issue/story

ent-3533

@cdcabrera cdcabrera added patternfly Patternfly UI/UX and implementation platform Contains, or is, platform specific work and issues 202104 project phase labels Feb 9, 2021
@cdcabrera cdcabrera merged commit 3849122 into RedHatInsights:ci Feb 9, 2021
cdcabrera added a commit that referenced this pull request Feb 16, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
5a75510
@cdcabrera cdcabrera mentioned this pull request Mar 4, 2021
Merged
cdcabrera added a commit that referenced this pull request Mar 5, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
078c316
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (RedHatInsi…
20c3488 
…ghts#580)
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (RedHatInsi…
92d2cfe 
…ghts#580)
cdcabrera added a commit that referenced this pull request Mar 25, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
79cd61f
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
2db4b4a
@cdcabrera cdcabrera mentioned this pull request Apr 13, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 13, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
f141eb3
@cdcabrera cdcabrera mentioned this pull request Apr 20, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 20, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
bbcc994
@cdcabrera cdcabrera mentioned this pull request Apr 22, 2021
Merged
cdcabrera added a commit that referenced this pull request Apr 26, 2021
@cdcabrera
fix(pageHeader): ent-3533 check consistent html for Pendo (#580)
059143e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
202104 project phase patternfly Patternfly UI/UX and implementation platform Contains, or is, platform specific work and issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cdcabrera