Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP perf(productViewOpenShift): openshiftView to productViewOpenShift #588

Closed
wants to merge 1 commit into from

Conversation

cdcabrera
Copy link
Member

What's included

  • perf(productViewOpenShift): openshiftView to productViewOpenShift

Notes

  • moves openshift to the same product view component that RHEL and Satellite use
  • applies a product context that can be consumed through hooks
  • similar product tests performed on RHEL and Satellite should be performed on OpenShift
  • This update allows us the ability to simplify our component structures enabling more efficient reuse based on "context" instead of prop drilling

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back without error

Example

...

Updates issue/story

ent-3324

@cdcabrera cdcabrera added story New feature, or process work 202104 project phase labels Feb 22, 2021
@cdcabrera
Copy link
Member Author

As of 20210302 this PR contains parallel work that has merged with #591 , we can still utilize the branch for artifact purposes in the short term

@cdcabrera cdcabrera closed this Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant