Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(productViewOpenShiftDedicated): ent-3324 base view #590

Merged
merged 5 commits into from
Feb 25, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 25, 2021

What's included

  • feat(productViewOpenShiftDedicated): ent-3324 base view
    • i18n, locale strings for OpenShift
    • inventoryList, Subscriptions, console confirmation for sorting
    • inventoryListHelpers, allow for missing data
    • productView, product label context
    • productViewOpenShiftDedicated, base view
    • routerConfig, OpenShift dedicated route
    • rhsmServices, mock API response, core hours
    • rhsmApiTypes, product IDs, core hours for sorting and inventory
  • fix(productView,openshiftView): ent-3324 align code for products
    • i18n, locale strings for products
    • graphCard, move granularity field into product view
    • productView, openshiftView customizable toolbars
  • fix(toolbarFieldRangedMonthly): ent-3507 disable selected options
    • toolbarFieldRangedMonthly, quick fix, string fails to match date
  • fix(select): ent-3507 object values, match selected options
  • fix(pageLayout): ent-3504 export pageColumns

Notes

  • This activates a non-linked version of the OpenShift Dedicated view. It also makes modifications to locale strings and components shared by all products
    • It is expected there may be issues with OpenShift Dedicated as the API is activated
  • @ntkathole @rblackbu @bclarhk

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back without error

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm RHEL, Satellite, and the original OpenShift views behave as intended. the following behaviors were affected across all products
    • tooltips/locale strings
    • select/dropdown lists
  5. navigate to OpenShift Dedicated at the following route /subscriptions/openshift-sw/dedicated
    • unexpected behavior may appear, API dependent

Example

Emulated example

Screen Shot 2021-02-24 at 11 17 31 PM

Emulated expectation once in environment

Screen Shot 2021-02-25 at 1 50 17 PM

Updates issue/story

ent-3324
ent-3507
ent-3504

@cdcabrera cdcabrera added story New feature, or process work 202104 project phase labels Feb 25, 2021
@cdcabrera cdcabrera force-pushed the ent-3324-openshift-dedicated branch from 84a4b38 to 2c3c7dd Compare February 25, 2021 17:31
…dHatInsights#590)

* toolbarFieldRangedMonthly, quick fix, string fails to match date
…HatInsights#590)

* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
…ts#590)

* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
@cdcabrera cdcabrera force-pushed the ent-3324-openshift-dedicated branch from 2c3c7dd to a002313 Compare February 25, 2021 18:44
@cdcabrera cdcabrera merged commit e5cf9d3 into RedHatInsights:ci Feb 25, 2021
cdcabrera added a commit that referenced this pull request Feb 25, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Feb 25, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Mar 5, 2021
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Mar 5, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
…dHatInsights#590)

* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
…HatInsights#590)

* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
…ts#590)

* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
…dHatInsights#590)

* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
…HatInsights#590)

* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 25, 2021
…ts#590)

* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Mar 25, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Apr 13, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Apr 20, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* toolbarFieldRangedMonthly, quick fix, string fails to match date
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* i18n, locale strings for products
* graphCard, move granularity field into product view
* productView, openshiftView customizable toolbars
cdcabrera added a commit that referenced this pull request Apr 26, 2021
* i18n, locale strings for OpenShift
* inventoryList, Subscriptions, console confirmation for sorting
* inventoryListHelpers, allow for missing data
* productView, product label context
* productViewOpenShiftDedicated, base view
* routerConfig, OpenShift dedicated route
* rhsmServices, mock API response, core hours
* rhsmApiTypes, product IDs, core hours for sorting and inventory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase story New feature, or process work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant