Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routerHelpers): dynamic route, handle additional directories #600

Merged
merged 2 commits into from
Mar 15, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(routerHelpers): dynamic route, handle additional directories

Notes

  • Aspects/views associated with the Subs Watch GUI are being pulled in other locations. This update allows multiple variations in directory structure as long as the application name is used, part of the original baseName checks.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added platform Contains, or is, platform specific work and issues 202104 project phase labels Mar 9, 2021
@cdcabrera cdcabrera added the blocked Prevented from continuing label Mar 9, 2021
@cdcabrera
Copy link
Member Author

cdcabrera commented Mar 9, 2021

Marking this update blocked until we can get a more specific response regarding the decision to use the paths

  • /insights/rhel-sw/[ARCHITECTURE] vs
  • /insights/subscriptions/rhel-sw/[ARCHITECTURE]

Currently the baseName and app identifiers are all based off of the path containing subscriptions. It's part of how Subs Watch is identified under the Platform and how the left nav functions, or at least used to function in conjunction with the views.

Under the assumption that the platform left nav still requires coordination from the GUI...

If this paradigm shifts towards using something like rhel-sw or openshift-sw or satellite-sw or any of the other potential products we're geared to consume in the future, that will generate effort that will potentially squash our existing timeline goals as of 20210309, it is an unexpected requirement.

It also has a side effect on future scenarios where we would be dependent on maintaining multiple unique identifiers in platform config for the sake of satisfying basic navigation?!

@cdcabrera cdcabrera removed the blocked Prevented from continuing label Mar 12, 2021
@cdcabrera
Copy link
Member Author

cdcabrera commented Mar 12, 2021

We have some additional routing updates that need to be performed to work with the platform navigation updates. We're considering adding to this PR or a new PR. They are...

  • /insights/subscriptions/rhel
  • /insights/subscriptions/rhel-arm
  • /insights/subscriptions/rhel-ibmpower
  • /insights/subscriptions/rhel-ibmz
  • /insights/subscriptions/rhel-x86
  • /openshift/subscriptions/openshift-dedicated
  • /openshift/subscriptions/openshift-container

The old routes are dependent on the prior way of navigating and grouping and should probably be removed, we'll need to evaluate the navigation updates to determine their removal, but that can be in a follow up PR. Relates RHCLOUD-12690

Coordinated config updates are here, RedHatInsights/cloud-services-config#446

cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 15, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 15, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 15, 2021
@cdcabrera cdcabrera merged commit edf4f1b into RedHatInsights:ci Mar 15, 2021
cdcabrera added a commit to cdcabrera/curiosity-frontend that referenced this pull request Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202104 project phase platform Contains, or is, platform specific work and issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant