-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(viewReducer): ent-3644 productGroups for inventory reset #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Mar 24, 2021
…nsights#606) * routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
to cdcabrera/curiosity-frontend
that referenced
this pull request
Mar 25, 2021
…nsights#606) * routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
that referenced
this pull request
Mar 25, 2021
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
that referenced
this pull request
Apr 13, 2021
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
that referenced
this pull request
Apr 13, 2021
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
that referenced
this pull request
Apr 20, 2021
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
cdcabrera
added a commit
that referenced
this pull request
Apr 26, 2021
* routerConfig, productGroups, productIds grouped by viewIds * toolbar, viewId to inventory reset * toolbarFieldDisplayName, granularity, ranged, uom, apply viewId * viewReducer, restructure reset to apply productGroups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
productId
alongside theviewId
, orviewId
and creating a dictionary for each viewId that relates all possibleproductIds
contained under aviewId
enabling us to reset state on those specific productIds. The advantage is it ties into future updates around custom hooks and contextHow to test
Proxy run check
$ yarn
$ yarn start:proxy
Example
...
Updates issue/story
ent-3644