Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service config clean up, Minor Routing update #62

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Jul 29, 2019

What's included

  • fix(services, router): remove unused auth header func

    • services config, clean up
    • router, redirect route adjust

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test

Interactive unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test:dev

Example

...

Updates issue/story

Updates #34

@codecov-io
Copy link

Codecov Report

Merging #62 into master will increase coverage by 1.14%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   87.24%   88.39%   +1.14%     
==========================================
  Files          23       23              
  Lines         298      293       -5     
  Branches       64       63       -1     
==========================================
- Hits          260      259       -1     
+ Misses         30       27       -3     
+ Partials        8        7       -1
Impacted Files Coverage Δ
src/services/config.js 100% <100%> (+57.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6402585...688e335. Read the comment docs.

@cdcabrera cdcabrera changed the title WIP Service config clean up, Issues/34 Routing update Service config clean up, Minor Routing update Jul 30, 2019
* services config, clean up
* router, redirect route adjust
@cdcabrera cdcabrera merged commit 3a12056 into RedHatInsights:master Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants