fix(build, routerTypes): issues/34 dynamic routing baseName #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
+ Coverage 88.09% 88.66% +0.57%
==========================================
Files 23 23
Lines 294 300 +6
Branches 62 64 +2
==========================================
+ Hits 259 266 +7
+ Misses 28 27 -1
Partials 7 7
Continue to review full report at Codecov.
|
cdcabrera
referenced
this pull request
in cdcabrera/curiosity-frontend
Aug 2, 2019
* build, dotenv path prefix * build, html template add in lang attribute from dotenv * routerTypes, create a dynamic routing baseName
* build, dotenv path prefix * build, html template add in lang attribute from dotenv * routerTypes, create a dynamic routing baseName
priley86
reviewed
Aug 2, 2019
| @@ -1,5 +1,5 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <html lang="%REACT_APP_CONFIG_SERVICE_LOCALES_DEFAULT_LNG%"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn$ yarn testInteractive unit test check
$ yarn$ yarn test:devLocal run
$ yarn$ yarn startrhelrouterhelpathhttp://localhost:3000/lorem/ipsum/dolor/sitshould end up being ->http://localhost:3000/lorem/ipsum/rhelhttp://localhost:3000/lorem/ipsum/rhel/rhel/rhelshould end up being ->http://localhost:3000/lorem/ipsum/rhelbetapath part of the check, first stop the previous local run server, then run$ export UI_DEPLOY_PATH_PREFIX=/beta; yarn start; unset UI_DEPLOY_PATH_PREFIXrhelpathhttp://localhost:3000/beta/lorem/ipsum/dolor/sitshould end up being ->http://localhost:3000/beta/lorem/ipsum/rhelhttp://localhost:3000/beta/lorem/ipsum/rhel/rhel/rhelshould end up being ->http://localhost:3000/beta/lorem/ipsum/rhelExample
...
Updates issue/story
Updates #34