Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): default branch to main #769

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Aug 19, 2021

What's included

  • chore(build): default branch to main

Notes

  • A rename of the default branch from master to main will take place after this merges. We may need to wait until this commit makes its way up towards prod to avoid breaking the badges... GitHub should redirect for a limited amount of time
  • It should be unnecessary to update any scripts or CI, this is primarily a documentation update. The process for this transition already accounts for multiple branch names in CI. Because we limited what the "main" branch represents, in our case "production", no Curiosity developer should be actively/directly using this branch. This in turn should limit downstream issues.

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm completion without errors

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. visual regression confirmation

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. visual regression confirmation

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm completion without errors

Example

...

Updates issue/story

Ongoing

@cdcabrera cdcabrera added the 202112 project phase label Aug 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #769 (12ce5a2) into ci (923eb56) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #769   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files         101      101           
  Lines        2823     2823           
  Branches     1024     1024           
=======================================
  Hits         2688     2688           
  Misses        128      128           
  Partials        7        7           
Impacted Files Coverage Δ
src/services/rhsmServices.js 100.00% <ø> (ø)
src/services/userServices.js 97.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 923eb56...12ce5a2. Read the comment docs.

@cdcabrera cdcabrera merged commit 82ddbca into RedHatInsights:ci Aug 19, 2021
cdcabrera added a commit that referenced this pull request Sep 15, 2021
cdcabrera added a commit that referenced this pull request Sep 22, 2021
cdcabrera added a commit that referenced this pull request Nov 30, 2021
cdcabrera added a commit that referenced this pull request Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants