Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(productViewOpenShiftContainer): ent-4367 hosts inventory #833

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(productViewOpenShiftContainer): ent-4367 hosts inventory

Notes

  • Minor error, the ocp view should NOT be pointed at the new instances API endpoint
  • This PR will be squashed with the prior feature commit

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the OCP product view has inventory API calls that use hosts instead of instances

Example

...

Updates issue/story

ent-4367

@cdcabrera cdcabrera added bug Something isn't working 202112 project phase labels Nov 17, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2021

Codecov Report

Merging #833 (b5d55ee) into ci (c3e19d2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #833   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files         123      123           
  Lines        3515     3515           
  Branches     1346     1346           
=======================================
  Hits         3305     3305           
  Misses        193      193           
  Partials       17       17           
Impacted Files Coverage Δ
...nents/productView/productViewOpenShiftContainer.js 85.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3e19d2...b5d55ee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202112 project phase bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants