Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bannerMessages): ent-4899 align hook components #926

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Apr 25, 2022

What's included

  • refactor(bannerMessages): ent-4899 align hook components

Notes

  • no visual updates associated with this refactor
  • aligns hook and component use across Curiosity
  • removes unused/minimally used original path/thinking for how "context" and "redux" should work

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests pass

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm banner message displays, or doesn't, accordingly

Example

Screen Shot 2022-04-26 at 3 41 16 PM

Updates issue/story

relates to ent-4669
ent-4899

@cdcabrera cdcabrera added the 202208 project phase label Apr 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022

Codecov Report

Merging #926 (c7db2d8) into ci (0350bfe) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #926   +/-   ##
=======================================
  Coverage   94.23%   94.23%           
=======================================
  Files         130      128    -2     
  Lines        3970     3958   -12     
  Branches     1557     1550    -7     
=======================================
- Hits         3741     3730   -11     
+ Misses        212      210    -2     
- Partials       17       18    +1     
Impacted Files Coverage Δ
src/services/rhsm/rhsmTransformers.js 95.65% <ø> (ø)
...components/bannerMessages/bannerMessagesContext.js 83.33% <83.33%> (ø)
src/components/bannerMessages/bannerMessages.js 100.00% <100.00%> (+10.00%) ⬆️
src/components/productView/productView.js 94.11% <100.00%> (ø)
src/redux/common/reduxHelpers.js 87.17% <0.00%> (-0.65%) ⬇️
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0350bfe...c7db2d8. Read the comment docs.

@cdcabrera cdcabrera merged commit dfb3645 into RedHatInsights:ci Apr 28, 2022
cdcabrera added a commit that referenced this pull request May 25, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
cdcabrera added a commit that referenced this pull request May 25, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
cdcabrera added a commit that referenced this pull request May 26, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* bannerMessages, context, bundle api call, logic into hook
* productView, context, move banner under product columns
* redux, clean up unused hooks for actions, remove selectors
* rhsmTransformers, cloudigradeHasMismatch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants