-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(bannerMessages): ent-4899 align hook components #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdcabrera
force-pushed
the
ent-4899-banner
branch
from
April 25, 2022 17:58
2b1cbd0
to
144b743
Compare
Codecov Report
@@ Coverage Diff @@
## ci #926 +/- ##
=======================================
Coverage 94.23% 94.23%
=======================================
Files 130 128 -2
Lines 3970 3958 -12
Branches 1557 1550 -7
=======================================
- Hits 3741 3730 -11
+ Misses 212 210 -2
- Partials 17 18 +1
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
May 25, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
cdcabrera
added a commit
that referenced
this pull request
May 25, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
cdcabrera
added a commit
that referenced
this pull request
May 26, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
cdcabrera
added a commit
that referenced
this pull request
Jun 14, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
Merged
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* bannerMessages, context, bundle api call, logic into hook * productView, context, move banner under product columns * redux, clean up unused hooks for actions, remove selectors * rhsmTransformers, cloudigradeHasMismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
How to test
Coverage and basic unit test check
$ yarn
$ yarn test
Proxy run check
$ yarn
$ yarn start:proxy
Example
Updates issue/story
relates to ent-4669
ent-4899