Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): npm updates #930

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

cdcabrera
Copy link
Member

What's included

  • chore(build): npm updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ yarn
  2. $ yarn test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ yarn
  2. $ yarn start
  3. confirm the GUI behavior is maintained

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. confirm the GUI behavior is maintained

Check the build

  1. update the NPM packages with $ yarn
  2. $ yarn build
  3. confirm the build completes without error

Example

...

Updates issue/story

ongoing

@cdcabrera cdcabrera added build 202208 project phase labels May 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #930 (c178899) into ci (4321c69) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##               ci     #930      +/-   ##
==========================================
+ Coverage   94.21%   94.23%   +0.02%     
==========================================
  Files         128      128              
  Lines        3958     3958              
  Branches     1550     1550              
==========================================
+ Hits         3729     3730       +1     
+ Misses        211      210       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/common/helpers.js 100.00% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4321c69...c178899. Read the comment docs.

@cdcabrera cdcabrera force-pushed the 20220502-build branch 2 times, most recently from 3df2def to b1ea1b0 Compare May 4, 2022 01:01
@cdcabrera cdcabrera merged commit 9a48326 into RedHatInsights:ci May 6, 2022
cdcabrera added a commit that referenced this pull request May 25, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
cdcabrera added a commit that referenced this pull request May 25, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
cdcabrera added a commit that referenced this pull request May 26, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
cdcabrera added a commit that referenced this pull request Jun 14, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera added a commit that referenced this pull request Jun 24, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
cdcabrera added a commit that referenced this pull request Jul 11, 2022
* build, expand deps check for core packages
* testing, update based on platform webpack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants