Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemeral Environments onboarding step 2 #932

Merged
merged 2 commits into from
May 23, 2022

Conversation

mirekdlugosz
Copy link
Collaborator

@mirekdlugosz mirekdlugosz commented May 18, 2022

What's included

  • Set IMAGE in build_deploy.sh and pr_check.sh scripts, see RHCLOUD-18589
  • Provide deploy/frontend.yaml file, required by frontend-operator to deploy curiosity on ephemeral env

IMAGE is URL of container image. If we want to change it from rhsm-frontend to whatever we want, now would be a good time. This name must match name in app-interface, but I'll handle the PR.

frontend.yaml is resource template. The idea is something like that:

  • bonfire will consult app-interfaces to get the list of applications and their components
  • component needs resource template to be deployable
  • depending on other flags, bonfire will deploy component or not

In other words: we need this file to create PR in app-interfaces adding frontend component to rhsm. And once app-interfaces PR is merged, we will be able to do:

bonfire deploy rhsm --frontends=true

This will reserve ephemeral namespace, deploy rhsm with all dependencies (rbac, cloudigrade, what have you) and deploy curiosity with all dependencies (chrome, landing page, dashboard). So you will get fully-functional SWatch in ephemeral environment.

Right now rhsm seems to be undeployable (times out while waiting for cloudigrade), but I am confident this reasoning is correct.

navItems is kind of a stub, it does not reflect menu structure currently used in prod / stage. In fact, it's not yet possible to re-create prod menu structure in ephemeral env (RHCLOUD-19211). But we can iterate over it later.

Updates issue/story

related #928

@mirekdlugosz mirekdlugosz requested a review from cdcabrera May 18, 2022 11:04
@codecov-commenter
Copy link

Codecov Report

Merging #932 (e735c04) into ci (9a48326) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##               ci     #932   +/-   ##
=======================================
  Coverage   94.21%   94.21%           
=======================================
  Files         128      128           
  Lines        3958     3958           
  Branches     1550     1550           
=======================================
  Hits         3729     3729           
  Misses        211      211           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a48326...e735c04. Read the comment docs.

@cdcabrera cdcabrera merged commit 1bdf958 into RedHatInsights:ci May 23, 2022
@cdcabrera cdcabrera added the 202208 project phase label May 24, 2022
cdcabrera pushed a commit that referenced this pull request May 25, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
cdcabrera pushed a commit that referenced this pull request May 25, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
cdcabrera pushed a commit that referenced this pull request May 26, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
cdcabrera pushed a commit that referenced this pull request Jun 14, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
@cdcabrera cdcabrera mentioned this pull request Jun 14, 2022
cdcabrera pushed a commit that referenced this pull request Jun 24, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
cdcabrera pushed a commit that referenced this pull request Jul 11, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
cdcabrera pushed a commit that referenced this pull request Jul 11, 2022
* add deploy/frontend.yaml
* IMAGE required, RHCLOUD-18589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202208 project phase build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants