-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ephemeral Environments onboarding step 2 #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ci #932 +/- ##
=======================================
Coverage 94.21% 94.21%
=======================================
Files 128 128
Lines 3958 3958
Branches 1550 1550
=======================================
Hits 3729 3729
Misses 211 211
Partials 18 18 Continue to review full report at Codecov.
|
e735c04
to
e7ae736
Compare
cdcabrera
pushed a commit
that referenced
this pull request
May 25, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
cdcabrera
pushed a commit
that referenced
this pull request
May 25, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
cdcabrera
pushed a commit
that referenced
this pull request
May 26, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
cdcabrera
pushed a commit
that referenced
this pull request
Jun 14, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
Merged
cdcabrera
pushed a commit
that referenced
this pull request
Jun 24, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
cdcabrera
pushed a commit
that referenced
this pull request
Jul 11, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
cdcabrera
pushed a commit
that referenced
this pull request
Jul 11, 2022
* add deploy/frontend.yaml * IMAGE required, RHCLOUD-18589
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
IMAGE
inbuild_deploy.sh
andpr_check.sh
scripts, see RHCLOUD-18589deploy/frontend.yaml
file, required by frontend-operator to deploy curiosity on ephemeral envIMAGE
is URL of container image. If we want to change it from rhsm-frontend to whatever we want, now would be a good time. This name must match name in app-interface, but I'll handle the PR.frontend.yaml
is resource template. The idea is something like that:In other words: we need this file to create PR in app-interfaces adding frontend component to rhsm. And once app-interfaces PR is merged, we will be able to do:
This will reserve ephemeral namespace, deploy rhsm with all dependencies (rbac, cloudigrade, what have you) and deploy curiosity with all dependencies (chrome, landing page, dashboard). So you will get fully-functional SWatch in ephemeral environment.
Right now rhsm seems to be undeployable (times out while waiting for cloudigrade), but I am confident this reasoning is correct.
navItems
is kind of a stub, it does not reflect menu structure currently used in prod / stage. In fact, it's not yet possible to re-create prod menu structure in ephemeral env (RHCLOUD-19211). But we can iterate over it later.Updates issue/story
related #928