fix(rhosak): ent-4982 storage GiB as GB hours to months #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* config, rhosak, use updated monthly metricId * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
* missing from spec, disabling for now
Codecov Report
@@ Coverage Diff @@
## ci #943 +/- ##
=======================================
Coverage 94.05% 94.05%
=======================================
Files 129 129
Lines 4020 4020
Branches 1571 1571
=======================================
Hits 3781 3781
Misses 221 221
Partials 18 18
Continue to review full report at Codecov.
|
cdcabrera
added a commit
that referenced
this pull request
Jun 3, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
cdcabrera
added a commit
that referenced
this pull request
Jun 3, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
cdcabrera
added a commit
that referenced
this pull request
Jun 14, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
Merged
cdcabrera
added a commit
that referenced
this pull request
Jun 24, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
cdcabrera
added a commit
that referenced
this pull request
Jul 11, 2022
* config, rhosak, use updated monthly metricId, disable sort * locale, add monthly metricId, shift prior monthly changes * services, constants, apply gib monthly metricId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
Storage-gibibyte-monthsis part of the sorting spec underInstanceReportSort, we're disabling it as part of this PR, it can be reactivated when the spec is updated, or otherwiseHow to test
Proxy run check
$ yarn$ yarn start:proxyExample
Updates issue/story
ent-4982