Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphCard): sw-223 generated key from settings #984

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(graphCard): sw-223 generated key from settings

How to test

Proxy run check

  1. update the NPM packages with $ yarn
  2. make sure Docker is running, plus on network, then
  3. $ yarn start:proxy
  4. open the dev console, then
    • navigate to an "on demand" product view within Subs
    • hitting refresh you should NO longer see the "duplicate key" console error

Example

...

Updates issue/story

sw-223
ent-4899
pr #927

@cdcabrera cdcabrera added the bug Something isn't working label Oct 12, 2022
@cdcabrera cdcabrera force-pushed the sw-223-ent-4899-key-fix branch from ed50453 to cfcd3b2 Compare October 12, 2022 21:14
@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #984 (cfcd3b2) into dev (7d65db8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #984      +/-   ##
==========================================
+ Coverage   93.79%   93.81%   +0.02%     
==========================================
  Files         129      129              
  Lines        4109     4109              
  Branches     1624     1624              
==========================================
+ Hits         3854     3855       +1     
+ Misses        237      236       -1     
  Partials       18       18              
Impacted Files Coverage Δ
src/components/graphCard/graphCard.js 91.66% <100.00%> (ø)
src/common/helpers.js 100.00% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d65db8...cfcd3b2. Read the comment docs.

@cdcabrera cdcabrera merged commit 1fb9799 into RedHatInsights:dev Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants