add improvements on subscription with activation key

[adeliaferreira]

Description

After hot fixes from last week, this PR will address some of comments we have open on subscription to image.
It's create a new func that will create the subscription object to fill "req.customizations.subscription" if adequate and more tests to validate it.

FIXES:

Type of change

What is it?

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Documentation update
• Tests update
• Refactor

[codecov-commenter]

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (cee7574) 62.58% compared to head (ae0c852) 62.74%.
Report is 3 commits behind head on main.

Files	Patch %	Lines
pkg/clients/imagebuilder/client.go	73.91%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2396      +/-   ##
==========================================
+ Coverage   62.58%   62.74%   +0.15%     
==========================================
  Files          88       88              
  Lines       13380    13409      +29     
==========================================
+ Hits         8374     8413      +39     
+ Misses       4323     4313      -10     
  Partials      683      683              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[omaciel]

I love that you created a helper function! Left a question for you. I was a bit confused with the tests, but I don't have time to review the entire test suite (maybe some of the context I'm missing is already set somewhere else?).

[mergify]

This pull request needs all conversation threads to be resolved. Could you fix it @adeliaferreira? 🙏

[ldjebran]

looks good , left some comments.

[mergify]

This pull request needs all conversation threads to be resolved. Could you fix it @adeliaferreira? 🙏

[ldjebran]

lgtm, many thanks Tay