Formatting: reorder python imports #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catastrophe-brandon
approved these changes
Jul 12, 2019
diegorafrh
approved these changes
Jul 15, 2019
Glutexo
force-pushed
the
reorder_python_imports
branch
from
564c295 to
5dcd020
Compare
|
Mergeable again. Essentially did it from ground up. Pipfile.lock had conflicts and running the script again is simpler than manually resolving conflicts. So maybe it’d be worth a new review. |
Added the reorder-python-imports package to the development dependencies.
Glutexo
force-pushed
the
reorder_python_imports
branch
from
5dcd020 to
cf6a9eb
Compare
Use the reorder-python-imports tool to reorder imports in all Python files. It separates them in three groups and splits them into multiple lines.
Glutexo
force-pushed
the
reorder_python_imports
branch
from
cf6a9eb to
edf96eb
Compare
|
Rebased once more to fix the conflicts. |
diegorafrh
approved these changes
Jul 23, 2019
|
This pull request has been approved again. Can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the reorder-python-imports package to the development dependencies. Used it to reorder imports in all Python files.
The tool has split the imports into three groups, ordered them alphabetically and split multiple imports into separate lines. This will be later done automatically by a pre-commit hook. #331
This is a part of the way to having the code cleanly formatted. #189