Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting: add pre-commit-hooks to dependencies #348

Merged
merged 1 commit into from
Jul 17, 2019

Conversation

Glutexo
Copy link
Collaborator

@Glutexo Glutexo commented Jul 12, 2019

Added the pre-commit-hooks package as a development dependency. This installs its bundled executables, making it possible to manually run the hooks like trailing-whitespace-fixer (#347).

This is a part of a way to fix the formatting in the whole repository. See #189 and #331.

@Glutexo Glutexo self-assigned this Jul 12, 2019
@Glutexo Glutexo changed the title Formatting add pre-commit-hooks to dependencies Formatting: add pre-commit-hooks to dependencies Jul 12, 2019
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 15, 2019

This has been approved. Merge @dehort, @lphiri?

Added the pre-commit-hooks package as a development dependency. This
installs its bundled executables, making it possible to manually run the
hooks like trailing-whitespace-fixer.
@Glutexo Glutexo force-pushed the standalone_hooks branch from 1296bd6 to eaed746 Compare July 17, 2019 09:39
@Glutexo
Copy link
Collaborator Author

Glutexo commented Jul 17, 2019

Added again because of the Pipfile.lock conflict.

@dehort dehort merged commit 032a060 into RedHatInsights:master Jul 17, 2019
@Glutexo Glutexo deleted the standalone_hooks branch July 18, 2019 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants