fix: Return non-zero code, when some sub-status is wrong #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jirihnidek
commented
Jul 17, 2024
jirihnidek
commented
- When some sub-status is not correct (system is not registered, insights-client is not registered or yggdrasil is not running), then return non-zero status code
- This change follow behavior of subscription-manager and it could help automation
* When some sub-status is not correct (system is not registered, insights-client is not registered or yggdrasil is not running), then return non-zero status code * This change follow behavior of subscription-manager and it could help automation
subpop
reviewed
Jul 17, 2024
| // At the end check if all statuses are correct. | ||
| // If not, return 1 exit code without any message. | ||
| if systemStatus.returnCode != 0 { | ||
| return cli.Exit("", 1) |
There was a problem hiding this comment.
Shouldn't this be?
Suggested change
| return cli.Exit("", 1) | |
| return cli.Exit("", systemStatus.returnCode) |
There was a problem hiding this comment.
Well, the value of systemStatus.returnCode depends on the number of "failed" sub-statuses. It could be 1, 2, 3, but we return value 1 for all other error cases.
I think that we should return different values for various situations (not only 1), but we should think twice before we do it and create some design document for that.
There was a problem hiding this comment.
Ok, so this change is just applying a non-zero return code when any sub-status is non-zero. Seems reasonable.
|
@Lorquas Is the downstream test failure something we should ignore for this PR? |
|
@subpop Jenkins job is constantly failing. I think that we can ignore it. |
jirihnidek
added a commit
that referenced
this pull request
Sep 12, 2024
* The returned value is non-zero, when some sub-task returns non-zero value. This change was introduced in this PR: #126 * We should check for non-zero code, not zero code in this case
jirihnidek
added a commit
that referenced
this pull request
Sep 12, 2024
* The returned value is non-zero, when some sub-task returns non-zero value. This change was introduced in this PR: #126 * We should check for non-zero code, not zero code in this case
Archana-PandeyM
pushed a commit
that referenced
this pull request
Sep 13, 2024
* The returned value is non-zero, when some sub-task returns non-zero value. This change was introduced in this PR: #126 * We should check for non-zero code, not zero code in this case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.