Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packit: tag cloud resources in Testing Farm #130

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

thrix
Copy link
Contributor

@thrix thrix commented Jul 29, 2024

This way we can track the cloud costs for the team and also provide more detailed team specific metrics.

@thrix
Copy link
Contributor Author

thrix commented Jul 29, 2024

Also let's wait for tests, so we can verify it is doing what it should be

@Lorquas Lorquas requested review from Lorquas and jirihnidek July 29, 2024 22:52
@jirihnidek
Copy link
Contributor

@thrix Thanks for PR. Can you please modify little bit commit message? The commit message should begin with one of the following category keyword: "build,ci,chore,docs,feat,fix,perf,refactor,revert,style,test"

@Lorquas
Copy link
Member

Lorquas commented Jul 30, 2024

Jenkins test this please.

@thrix thrix force-pushed the add-testing-farm-tag branch from 5a70d68 to ae2f000 Compare July 31, 2024 08:02
@thrix
Copy link
Contributor Author

thrix commented Jul 31, 2024

hopefully ok now

.packit.yml Outdated
settings:
provisioning:
tags:
BusinessUnit: RedHatInsights@public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you choose this business unit? According to this documentation https://packit.dev/docs/configuration/examples#tests it should be RHEL sst name. Our sst name is something different.

@thrix thrix force-pushed the add-testing-farm-tag branch from ae2f000 to e56036b Compare July 31, 2024 08:40
This way we can track the cloud costs for the team and also
provide more detailed team specific metrics.

Signed-off-by: Miroslav Vadkerti <[email protected]>
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jirihnidek jirihnidek merged commit 59ef9cc into RedHatInsights:main Jul 31, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants