fix: control messages not using uuid #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think something similar can be done for Event message type. |
ahitacat
force-pushed
the
fix-control-msg-uuid
branch
2 times, most recently
from
ded1b12 to
9b282c0
Compare
subpop
requested changes
May 19, 2023
ahitacat
force-pushed
the
fix-control-msg-uuid
branch
from
9b282c0 to
6a1ba74
Compare
subpop
requested changes
May 22, 2023
ahitacat
force-pushed
the
fix-control-msg-uuid
branch
from
6a1ba74 to
fcc69b0
Compare
This commits fix the use of uuid in control messages by modifying Command message to just contains the Content structure of the Control message. This commits also fix some logic on generateControlMessage. Signed-off-by: Alba Hita Catala <[email protected]>
ahitacat
force-pushed
the
fix-control-msg-uuid
branch
from
fcc69b0 to
46e5a17
Compare
subpop
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits fix the use of
uuidin control messages by modifying Command message to just contains the Content structure of the Control message.This commits also fix some logic on
generateControlMessage.