feat(mqtt): Use Token.WaitTimeout #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subpop
force-pushed
the
token-wait-timeout
branch
from
d11df1c to
01e623c
Compare
subpop
force-pushed
the
token-wait-timeout
branch
from
01e623c to
5453891
Compare
jirihnidek
requested changes
Oct 3, 2023
When connecting to a broker and when publishing a message, use the `Token.WaitTimeout` method instead of `Token.Wait`. `Token.Wait` waits indefinitely, which can lead to situations when the client never succeeds in connecting or publishing. The timeout for each operation can be configured independently by setting `mqtt-connect-timeout` and `mqtt-publish-timeout`. Both values default to 30 seconds. The flags are hidden, as they should not commonly be required to be changed by users. Signed-off-by: Link Dupont <[email protected]> Signed-off-by: Link Dupont <[email protected]>
subpop
force-pushed
the
token-wait-timeout
branch
from
5453891 to
d69e55f
Compare
jirihnidek
approved these changes
Oct 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting to a broker and when publishing a message, use the
Token.WaitTimeoutmethod instead ofToken.Wait.Token.Waitwaitsindefinitely, which can lead to situations when the client never
succeeds in connecting or publishing.
The timeout for each operation can be configured independently by
setting
mqtt-connect-timeoutandmqtt-publish-timeout. Both valuesdefault to 30 seconds. The flags are hidden, as they should not commonly
be required to be changed by users.
Signed-off-by: Link Dupont [email protected]