Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve error and debug messaging #238

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jirihnidek
Copy link
Contributor

@jirihnidek jirihnidek force-pushed the jhnidek/more_debug_messages branch from 5de19db to cf87b21 Compare June 25, 2024 14:17
@jirihnidek
Copy link
Contributor Author

packit did all checks in 25 minutes ... 👎

Copy link
Collaborator

@subpop subpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have a couple tiny grammar changes, but otherwise this is good. Very nice improvements.

internal/work/dispatcher.go Outdated Show resolved Hide resolved
internal/work/dispatcher.go Outdated Show resolved Hide resolved
* Improved messaging in various cases (mostly related to
  D-Bus methods and signals)
* All changes comes from closed PR #157 (running yggdrasil
  as non-root user)
@jirihnidek jirihnidek force-pushed the jhnidek/more_debug_messages branch from a85d5d0 to a9d07a8 Compare July 15, 2024 12:29
@subpop subpop merged commit 5186522 into main Jul 15, 2024
18 checks passed
@subpop subpop deleted the jhnidek/more_debug_messages branch July 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants