feat: add client-id subcommand to yggctl #259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirihnidek
requested changes
Sep 10, 2024
cmd/yggctl/actions.go
Outdated
| @@ -173,6 +173,23 @@ func messageJournalAction(ctx *cli.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func clientIDAction(ctx *cli.Context) error { | |||
There was a problem hiding this comment.
Doc string for this function is missing
cmd/yggctl/actions.go
Outdated
| obj := conn.Object("com.redhat.Yggdrasil1", "/com/redhat/Yggdrasil1") | ||
| var clientID string | ||
| if err := obj.Call("com.redhat.Yggdrasil1.GetClientID", dbus.Flags(0)).Store(&clientID); err != nil { | ||
| return cli.Exit(fmt.Errorf("cannot retrieve client id: %v", err), 1) |
There was a problem hiding this comment.
I would add more information to this error message. E.g. what object was called. Otherwise you get this error message:
user@localhost:~/path/to/yggdrasil$ go run ./cmd/yggctl client-id
cannot retrieve client id: The name is not activatable
exit status 1
|
|
|
Thanks for the initial review @jirihnidek . |
DuckBoss
force-pushed
the
jajerome/client-id-subcmd
branch
from
9f973ed to
876aa11
Compare
subpop
requested changes
Sep 11, 2024
dbus/com.redhat.Yggdrasil1.xml
Outdated
|
|
||
| Returns the current client id on the interface. | ||
| --> | ||
| <method name="GetClientID"> |
There was a problem hiding this comment.
Did you try defining this as a D-Bus object property rather than a "getter" method?
DuckBoss
force-pushed
the
jajerome/client-id-subcmd
branch
from
876aa11 to
90b7818
Compare
This patch adds a 'client-id' subcommand to yggctl which retrieves and prints to stdout the active client ID of a yggd instance. This attempts to resolve issue RedHatInsights#243 Signed-off-by: Jason Jerome <[email protected]>
DuckBoss
force-pushed
the
jajerome/client-id-subcmd
branch
from
90b7818 to
9a45f83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a 'client-id' subcommand
to yggctl which retrieves and prints to stdout
the active client ID of a yggd instance.
This attempts to resolve issue #243