Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update botocore version #443

Merged
merged 1 commit into from
Mar 26, 2021
Merged

update botocore version #443

merged 1 commit into from
Mar 26, 2021

Conversation

tstrych
Copy link
Contributor

@tstrych tstrych commented Feb 8, 2021

botocore requires update

update reasoning is explained in this robottelo issue.

My steps:
I found boto and boto3 is dependant, boto version is not specified in setup.cfg but boto3 is so I looked at boto3 versions and found 1.12.0, random release that was after 1.14.0.
Then I let pip to installed boto3
pip install boto3 == 1.12.0 and botocore >= 1.14.0 and pip installed botocore 1.15.49

@tstrych
Copy link
Contributor Author

tstrych commented Feb 8, 2021

wrapanapi/systems/ec2.py:8:from botocore.config import Config
wrapanapi/systems/ec2.py:9:from botocore.exceptions import ClientError

we use only those from botocore, and there were no important change in ClientError and Config between those versions
only change in ClientError
Screenshot from 2021-02-08 17-28-45
only change in Config
Screenshot from 2021-02-08 17-19-51

and for boto3:

from boto3 import resource
from boto3 import client
boto3.__version__ - ( I hope this is just a property and is set up automatically, so I didn't check that) 

i didn't found any files in comparism that metions resources or client. I found documentation

I found those files in this directory and both of them (client, resource) are without change for multiple years.

@mshriver mshriver merged commit 2cf0608 into RedHatQE:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants