Add support for AWS Resource Explorer #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apodhrad
force-pushed
the
aws-resource-explorer
branch
from
7a9f647 to
cb9dbea
Compare
|
pre-commit.ci autofix |
jyejare
requested changes
Oct 15, 2023
apodhrad
force-pushed
the
aws-resource-explorer
branch
from
bfafd67 to
f9467d8
Compare
|
Hi @jyejare thanks for the review. I have applied all your suggestions. |
|
@apodhrad Please make sure that the pre-commit checks are passing. I see that black is complaining about bad formatting. If do not plan any further changes, you can simply comment Edit: Also some of the unit tests failed to collect. Can you please take a look at the failures too? They seem to be related to the typing you added. |
apodhrad
force-pushed
the
aws-resource-explorer
branch
from
f9467d8 to
3609867
Compare
Signed-off-by: Andrej Podhradsky <[email protected]>
apodhrad
force-pushed
the
aws-resource-explorer
branch
from
3609867 to
39304b6
Compare
ogajduse
approved these changes
Oct 23, 2023
jyejare
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.