Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index_type JSON #111

Merged
merged 6 commits into from
Jun 9, 2021
Merged

Add index_type JSON #111

merged 6 commits into from
Jun 9, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 8, 2021 •
edited
Loading

Codecov Report

Merging #111 (c5c10cc) into master (07c4e29) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   76.81%   76.90%   +0.08%     
==========================================
  Files          13       13              
  Lines        1100     1104       +4     
==========================================
+ Hits          845      849       +4     
  Misses        198      198              
  Partials       57       57
Impacted Files Coverage Δ
redisearch/index.go 96.77% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c4e29...c5c10cc. Read the comment docs.

@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review June 8, 2021 08:17
@AvitalFineRedis AvitalFineRedis linked an issue Jun 8, 2021 that may be closed by this pull request
Add support for JSON type Index #110
Closed
filipecosta90
filipecosta90 requested changes Jun 9, 2021
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
AvitalFineRedis and others added 2 commits June 9, 2021 20:57
@AvitalFineRedis @filipecosta90
Update .circleci/config.yml
aaa00ee 
Co-authored-by: filipe oliveira <[email protected]>
@AvitalFineRedis @filipecosta90
Update .circleci/config.yml
c5c10cc 
Co-authored-by: filipe oliveira <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis merged commit 8c86ddb into master Jun 9, 2021
@AvitalFineRedis AvitalFineRedis deleted the Json_index_type branch June 9, 2021 19:50
@AvitalFineRedis AvitalFineRedis restored the Json_index_type branch June 28, 2021 06:47
@AvitalFineRedis AvitalFineRedis deleted the Json_index_type branch June 28, 2021 07:06
@gkorland gkorland mentioned this pull request Apr 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipecosta90 filipecosta90 filipecosta90 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for JSON type Index
3 participants
@AvitalFineRedis @filipecosta90 @gkorland