Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FT.ADDHASH command #62

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Conversation

dengliming
Copy link
Contributor

A PR for #57

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.04%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   72.74%   72.78%   +0.04%     
==========================================
  Files          12       12              
  Lines        1108     1117       +9     
==========================================
+ Hits          806      813       +7     
- Misses        239      240       +1     
- Partials       63       64       +1     
Impacted Files Coverage Δ
redisearch/client.go 79.61% <77.77%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76b1c66...6514978. Read the comment docs.

Copy link
Collaborator

@filipecosta90 filipecosta90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there @dengliming , can we include already the change in the README.md supported commands table?

@dengliming
Copy link
Contributor Author

@filipecosta90 It was done. Thanks for your reviewing.

@filipecosta90 filipecosta90 self-requested a review April 20, 2020 13:43
@filipecosta90
Copy link
Collaborator

@filipecosta90 It was done. Thanks for your reviewing.

Thanks @dengliming . Merging 👍

@filipecosta90 filipecosta90 merged commit b4cac87 into RediSearch:master Apr 20, 2020
@filipecosta90 filipecosta90 mentioned this pull request Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants