-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for RediSearch v2.0 Index Definition #81
Conversation
…backwards compatible
This pull request introduces 1 alert when merging 55d65fa into 207c949 - view on LGTM.com new alerts:
|
…AddHash. Deprecated SynAdd.
This pull request introduces 1 alert when merging 0d15c28 into 207c949 - view on LGTM.com new alerts:
|
…ediSearch version is bellow 20000 ( v2.0 )
Codecov Report
@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 76.18% 77.06% +0.87%
==========================================
Files 12 13 +1
Lines 1205 1273 +68
==========================================
+ Hits 918 981 +63
- Misses 227 232 +5
Partials 60 60
Continue to review full report at Codecov.
|
This pull request introduces 1 alert when merging 4b79274 into 207c949 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 08e9562 into 207c949 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 4958ddc into 207c949 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, small comments, let me know what you think.
This pull request introduces 1 alert when merging eb0a92d into 207c949 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging d334849 into 207c949 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging c0188dd into 207c949 - view on LGTM.com new alerts:
|
Valid points :) made getRediSearchVersion internal so that we use it only for tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR follows the release of the first milestone in the development of RediSearch 2.0.
RediSearch 2.0, marks the re-architecture of the way indices are kept in sync with the data. Instead of having to write data through the index (using the FT.ADD command), RediSearch will now follow the data written in hashes and automatically index it. as follows:
API changes on RediSearch 2.0 that need to be reflected on the client
As noted here, RediSearch 2.0 milestone includes several changes to the API:
Client Changes addressed in this PR
CreateIndexWithIndexDefinition
to enable specifying a index definition for automatic indexing on Hash updateExampleClient_CreateIndexWithIndexDefinition
AddHash
and made reference to HSET usage. Included example namedExampleClient_CreateIndexWithIndexDefinition
SynAdd
and made reference to use SynUpdate instead