fix: do not crash on incompatible allOf, console.warn instead

fixes #1156
Redocly · May 10, 2020 · 6e607b9 · 6e607b9
1 parent 8460659
commit 6e607b9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/Schema/Schema.tsx b/src/components/Schema/Schema.tsx
@@ -43,9 +43,10 @@ export class Schema extends React.Component<Partial<SchemaProps>> {
 
     if (discriminatorProp !== undefined) {
       if (!oneOf || !oneOf.length) {
-        throw new Error(
+        console.warn(
           `Looks like you are using discriminator wrong: you don't have any definition inherited from the ${schema.title}`,
         );
+        return null;
       }
       return (
         <ObjectSchema

diff --git a/src/services/OpenAPIParser.ts b/src/services/OpenAPIParser.ts
@@ -239,7 +239,9 @@ export class OpenAPIParser {
         receiver.type !== undefined &&
         subSchema.type !== undefined
       ) {
-        throw new Error(`Incompatible types in allOf at "${$ref}"`);
+        console.warn(
+          `Incompatible types in allOf at "${$ref}": "${receiver.type}" and "${subSchema.type}"`,
+        );
       }
 
       if (subSchema.type !== undefined) {