Bugfix/heading safe guard #179 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until angular/protractor#3963 is merged This reverts commit 117d5bf.
…djusting some commentary and spelling/typos
…x/heading to bugfix/heading-safe-guard * commit '47c80f60bae648dcaaa5191841eff07b4b0b5696': fix(heading): fix for headings render making failsafe, adding test, adjusting some commentary and spelling/typos
|
@jsmartfo thanks for PR. But I've been working on search for ReDoc in another branch and have already refactored that peace of code. Sorry for not letting you know.. |
Until angular/protractor#3963 is merged This reverts commit 117d5bf.
…djusting some commentary and spelling/typos
…anexpress/ReDoc into bugfix/heading-safe-guard Rebase with redoc-search
|
@jsmartfo thank you! |
|
Appreciate you taking some of it anyway! Will look to help out more in the future, hope that's okay? Great project |
Would be awesome! Thanks for offering help here 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off the discussion here #179, adding logic to check if no heading-1 present then reassign the heading-2 to be heading-1.
This allows code to continue without error.
Another variation on this would be to leave the heading-2 the user defined but also create a heading-1 in the background this would however lead to a slight dupe within the menu and docs.