Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information to README about Docker image & Docker Hub #676

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Add information to README about Docker image & Docker Hub #676

merged 1 commit into from
Oct 18, 2018

Conversation

flaksp
Copy link
Contributor

@flaksp flaksp commented Oct 18, 2018

This pull request relates to #657.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.006% when pulling 1776754 on neluzhin:patch-1 into a665254 on Rebilly:master.

@RomanHotsiy RomanHotsiy merged commit 97db54a into Redocly:master Oct 18, 2018
@RomanHotsiy
Copy link
Member

Nice! The one issue is that the badge tells "Repo not found":

img

But I think that may be caching issue.

Thanks for your efforts!

@RomanHotsiy
Copy link
Member

Also, do you know how to force Docker Hub to not overwrite README.io each time or use a separate one?

@flaksp
Copy link
Contributor Author

flaksp commented Oct 18, 2018

@RomanGotsiy, seems like you can't use your description, because it will be overwritten after each build. As described in docs:

The build process looks for a README.md in the same directory as your Dockerfile. If you have a README.md file in your repository, it is used in the repository as the full description. If you change the full description after a build, it’s overwritten the next time the Automated Build runs. To make changes, modify the README.md in your Git repository.

@flaksp
Copy link
Contributor Author

flaksp commented Oct 18, 2018

Nice! The one issue is that the badge tells "Repo not found":

img

@RomanGotsiy, I see you've created "Repository", not "Automated Build", that's because badge can't find your repo:

image

Am I right?

williamboman added a commit to williamboman/ReDoc that referenced this pull request Oct 19, 2018
* upstream/master:
  docs: Add information to README about Docker image & Docker Hub (Redocly#676)
  chore: Release 2.0.0-alpha.41 🔖
  chore: fix lint issue
  fix: add null check in dispose method (Redocly#675)
  chore: fix cli ts compiling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants