Show all the mapping entries

[zeapo]

When the discriminator has mapping with more than one key pointing to the same ref. Only the last one was shown.
The following example would show only kitten, dog and bee in the dropdown. We'd expect to have all four (i.e. cat also!).

      discriminator:
        propertyName: petType
        mapping:
          cat: '#/components/schemas/Cat'
          kitten: '#/components/schemas/Cat'
          dog: '#/components/schemas/Dog'
          bee: '#/components/schemas/HoneyBee'

In this PR. The dropdown will show all the mappings:

Another use-case is when the mapping is partial, here the dog mapping was removed:

      discriminator:
        propertyName: petType
        mapping:
          cat: '#/components/schemas/Cat'
          kitten: '#/components/schemas/Cat'
          bee: '#/components/schemas/HoneyBee'

The type Dog will be included in addition to the mappings:

The third use-case is an exhaustive mapping, in that case we'd like to ignore non-mapping child classes. I've added a new extension x-limitToMapping of type boolean. When used, it excludes the class Dog in the following case:

      discriminator:
        propertyName: petType
        x-limitToMapping: true
        mapping:
          cat: '#/components/schemas/Cat'
          kitten: '#/components/schemas/Cat'
          bee: '#/components/schemas/HoneyBee'

will yield the following result:

[coveralls]

Coverage increased (+0.05%) to 82.302% when pulling bdbb6b4 on zeapo:fix-non-uniq-mapping into 70faca1 on Rebilly:master.

[zeapo]

Any news on this?

[RomanHotsiy]

Sorry for the delay. I am busy right now.
I will get to this till the end of the month.

[zeapo]

Hi,
Can you please look at this PR? It's really disturbing to have only 2 items showing when I've defined 4 in the mapping.

[RomanHotsiy]

I checked the PR. It looks good to me.
The only thing I don't like is the name of the vendor extension x-exhaustiveMapping.

I also don't quite like introducing new vendor extension as the other tooling won't support this use-case. I see your use case though.
Let me think a few more days about some alternatives.

If you have any suggestion throw it in pls

[sairon]

Hi @RomanHotsiy, have you reached any conclusion? I hit this issue as well and I'm looking for some solution. I can also help with creating a rebased and updated PR if @zeapo is not available, just your design decision is needed.

[zeapo]

I'm waiting for an update. I'm using my fork until there is a decision. I believe that the flag has to be available. Le mer. 31 juil. 2019 à 19:19, Jan Čermák <[email protected]> a écrit :

…

Hi @RomanHotsiy <https://github.com/RomanHotsiy>, have you reached any conclusion? I hit this issue as well and I'm looking for some solution. I can also help with creating a rebased and updated PR if @zeapo <https://github.com/zeapo> is not available, just your design decision is needed. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#774?email_source=notifications&email_token=AACCABQAZF7TJDCOJGXPVUTQCHJRLA5CNFSM4GOVPTEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3IDVNI#issuecomment-516962997>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACCABQZGBOWPLNXRTYUSYTQCHJRLANCNFSM4GOVPTEA> .

[adamaltman]

If I understand the feature, it's to use the mapping exactly as defined, and it's not necessarily exhaustive if you explicitly remove an item from your mapping definition it could still be discriminated.

Some alternative name ideas:

x-definedMapping
x-limitToMapping
x-limitToDefinedMapping

Please help with more ideas.

[zeapo]

@adamaltman That's exactly it. I like the x-limitToMapping as it conveys what this PR is intended to provide.

[adamaltman]

@zeapo the next step is to resolve conflicts and rename to x-limitToMapping. Did you want to update your PR?

[zeapo]

Yup, I'll update my PR.

[mohdzohlof]

Hello @RomanHotsiy, hope you have time to look into this PR soon. We have also hit this issue and are looking for a fix.

[zeapo]

It's indeed almost a year since this PR is open, and it's used in production on our side with no issues. I don't understand why It's taking that much time.

[zeapo]

Just an update, this PR is now officially 1 year and a few weeks old

[zeapo]

Can we bump this a little @RomanHotsiy ?

[zeapo]

I've just took a look at the conflict. From the look of it, the duplications are no more. There still the issue of Classes showing in the discriminator even if they are not listed in the mapping.
Another issue, the order in the mapping is no longer respected...
This is the result:

given the discriminator:

      discriminator:
        propertyName: petType
        mapping:
          dog: "#/components/schemas/Dog"
          doggy: "#/components/schemas/Dog"
          cat: "#/components/schemas/Cat"
          bee: "#/components/schemas/HoneyBee"

[zeapo]

replaced by #1215