Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move remove-unused-components decorator to decorators folder #1316

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Oct 27, 2023

What/Why/How?

Moving the remove-unused-components decorator from rules to decorators folder. No functional changes.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2023

⚠️ No Changeset found

Latest commit: 6031651

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr force-pushed the chore/move-a-decorator-out-of-rules branch from 62431c5 to 71f3b98 Compare October 27, 2023 15:33
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.321 ± 0.025 1.271 1.348 1.00 ± 0.03
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.320 ± 0.028 1.295 1.395 1.00

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.12% 4057/5330
🟡 Branches 65.95% 2152/3263
🟡 Functions 68.3% 657/962
🟡 Lines 76.31% 3805/4986
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / remove-unused-components.ts
83.87% 84.62% 66.67% 86.21%
🟢
... / remove-unused-components.ts
93.94% 86.67% 100% 96.77%

Test suite run success

646 tests passing in 93 suites.

Report generated by 🧪jest coverage report action from 6031651

@tatomyr tatomyr self-assigned this Oct 31, 2023
@tatomyr tatomyr marked this pull request as ready for review November 2, 2023 08:39
@tatomyr tatomyr requested a review from a team as a code owner November 2, 2023 08:39
@tatomyr tatomyr force-pushed the chore/move-a-decorator-out-of-rules branch from adfa855 to 7c5e109 Compare November 7, 2023 16:40
@tatomyr tatomyr force-pushed the chore/move-a-decorator-out-of-rules branch from 7c5e109 to fbad987 Compare November 9, 2023 07:59
@tatomyr tatomyr merged commit 3f13cb9 into main Nov 9, 2023
28 checks passed
@tatomyr tatomyr deleted the chore/move-a-decorator-out-of-rules branch November 9, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants