Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update eslint to sort out imports #1655

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Aug 1, 2024

What/Why/How?

Updated eslint to sort out regular and type imports.
No code changes.
Most changes are simply reordering of the imports.
Except for a couple of eslint warningns suppressed, removed unnecessary types, and tuned up code coverage thresholds.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: 8060bd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tatomyr tatomyr self-assigned this Aug 1, 2024
@tatomyr tatomyr force-pushed the chore/reorder-imports branch from d2543f9 to 74f2506 Compare August 1, 2024 18:44
Copy link
Contributor

github-actions bot commented Aug 1, 2024

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 973.4 ± 30.0 940.0 1049.9 1.01 ± 0.04
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 966.6 ± 16.2 948.1 991.9 1.00

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.5% 4664/6018
🟡 Branches 65.99% 1938/2937
🟡 Functions 71.38% 763/1069
🟡 Lines 77.71% 4401/5663
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / config-resolvers.ts
84.18% 67.23% 100% 84.97%

Test suite run success

759 tests passing in 107 suites.

Report generated by 🧪jest coverage report action from 8060bd2

@tatomyr tatomyr force-pushed the chore/reorder-imports branch from 97ecb74 to 8060bd2 Compare August 1, 2024 19:11
@RomanHotsiy RomanHotsiy marked this pull request as ready for review August 12, 2024 07:17
@RomanHotsiy RomanHotsiy requested a review from a team as a code owner August 12, 2024 07:17
@RomanHotsiy RomanHotsiy merged commit d0fc69c into main Aug 12, 2024
30 checks passed
@RomanHotsiy RomanHotsiy deleted the chore/reorder-imports branch August 12, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants