Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add webhooks to stats and fix crash for webhooks tags #1663

Merged
merged 6 commits into from
Aug 14, 2024

Conversation

RomanHotsiy
Copy link
Member

What/Why/How?

stats command was crashing for GitHub API (tags was undefined).

Also added support for webhooks in stats.

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@RomanHotsiy RomanHotsiy requested a review from a team as a code owner August 14, 2024 11:49
Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: f58a746

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.000 ± 0.018 0.974 1.032 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.006 ± 0.022 0.972 1.035 1.01 ± 0.03

@RomanHotsiy RomanHotsiy requested a review from a team as a code owner August 14, 2024 11:51
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.49% 4664/6019
🟡 Branches 65.94% 1938/2939
🟡 Functions 71.38% 763/1069
🟡 Lines 77.7% 4401/5664
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / stats.ts
10% 0% 0% 5.26%

Test suite run success

759 tests passing in 107 suites.

Report generated by 🧪jest coverage report action from f58a746

Copy link
Contributor

@tatomyr tatomyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RomanHotsiy RomanHotsiy merged commit d6580ea into main Aug 14, 2024
30 checks passed
@RomanHotsiy RomanHotsiy deleted the fix-stats-and-webhooks branch August 14, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants