-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate from node-fetch to native fetch #1848
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 14b4041 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Coverage report
Show files with reduced coverage 🔻
Test suite run success835 tests passing in 120 suites. Report generated by 🧪jest coverage report action from 14b4041 |
61b597a
to
4b4a862
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the remaining punycode from dependencies? Let's solve it. This warning is very annoying :(
@DmitryAnansky if we drop NodeJS prior to v16, we can remove the smoke tests for those here and here. |
sure, it is also strange that they are passing :) with the updated package.json. |
827781a
to
064a85c
Compare
The smokes don't cover anything specific to fetching data, only basic operations in different environment. |
What/Why/How?
Reference
Testing
Screenshots (optional)
Check yourself
Security