Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint oas3.1 unevaluatedProperties as boolean #621

Conversation

AlbertoFdzM
Copy link
Contributor

What/Why/How?

Fixes lint oas3.1 unevaluatedProperties as boolean by updating lint logic

Reference

#620

Testing

Added the next endpoint to /__tests__/lint/oas3.1/openapi.yaml

  /unevaluated-properties:
    get:
      operationId: getUnevaluatedProperties
      summary: Checks if unevaluetedProperties work
      responses:
        200:
          description: 'OK'
          content:
            application/json:
              schema:
                allOf:
                  - type: object
                    properties:
                      foo:
                        type: string
                  - type: object
                    properties:
                      bar:
                        type: number
                unevaluatedProperties: false
        400:
          description: An error response

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested a review from AntonKozachuk April 8, 2022 14:56
@tatomyr
Copy link
Contributor

tatomyr commented Apr 8, 2022

Thank you @AlbertoFdzM for your contribution!

@tatomyr tatomyr merged commit f4dd2ef into Redocly:master Apr 8, 2022
@tatomyr tatomyr mentioned this pull request Apr 12, 2022
5 tasks
@AlbertoFdzM AlbertoFdzM deleted the bugfix/620-admit-booleans-on-unevaluatedproperties branch April 24, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants