Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove "_" from types #636

Merged
merged 1 commit into from
Apr 12, 2022
Merged

chore: remove "_" from types #636

merged 1 commit into from
Apr 12, 2022

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Apr 12, 2022 •
edited
Loading

What/Why/How?

Removing "_" from listOf and mapOf type names for them to be consistent with the others.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr self-assigned this Apr 12, 2022
@tatomyr tatomyr requested a review from RomanHotsiy April 12, 2022 08:15
@tatomyr tatomyr merged commit 1c8a508 into master Apr 12, 2022
@tatomyr tatomyr deleted the chore/remove-underscore-from-types branch April 12, 2022 09:05
@tatomyr tatomyr mentioned this pull request Apr 12, 2022
Merged
5 tasks
@adamaltman
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanHotsiy RomanHotsiy RomanHotsiy approved these changes

Assignees

@tatomyr tatomyr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tatomyr @adamaltman @RomanHotsiy