Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 v55 #50

Merged
merged 32 commits into from
Aug 24, 2019
Merged

5.1.0 v55 #50

merged 32 commits into from
Aug 24, 2019

Conversation

AnnoraAki
Copy link
Contributor

No description provided.

@AnnoraAki AnnoraAki requested review from Hosigus and Fxy4ever August 24, 2019 06:20
.gitmodules Outdated
@@ -55,3 +55,6 @@
[submodule "module_redrock_home"]
path = module_redrock_home
url = [email protected]:CyxbsMobile-Android-Submodule/module_redrock_home.git
[submodule "module_freshman"]
path = module_freshman
url = https://github.com/CyxbsMobile-Android-Submodule/module_freshman
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里能不能用ssh,可以的话尽量统一,这设计到本地账号设置的原因,统一成ssh就不用登陆github账号

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle版本有升的必要吗

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我也觉得没必要...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

刚刚降了一下,版本下降至原来的4.4会导致androidx版本转换在编译的时候出现重复引用不同版本包的问题(我也看了一下,太多了,没办法改),查了资料也是要求的迁移androidX的版本需要在gradle版本4.6及其以上,所以就不做更改了

@@ -1,4 +1,4 @@
ext.gradle_plugins = '3.1.4'
ext.gradle_plugins = '3.4.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个升的影响?

@AnnoraAki AnnoraAki changed the title 5.1.0 v54 5.1.0 v55 Aug 24, 2019
@AnnoraAki AnnoraAki requested a review from Hosigus August 24, 2019 13:41
Copy link
Contributor

@Hosigus Hosigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有几个模块androidx的后遗症没有完全清理干净,之后有空再看看

@Hosigus Hosigus self-requested a review August 24, 2019 14:54
Copy link
Contributor

@Hosigus Hosigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有几个模块androidx的后遗症没有完全清理干净,之后有空再看看

@Fxy4ever Fxy4ever merged commit 9203cb1 into master Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants